[ 
https://issues.apache.org/jira/browse/MPH-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16766889#comment-16766889
 ] 

Hervé Boutemy edited comment on MPH-160 at 2/15/19 11:38 AM:
-------------------------------------------------------------

initial implementation of Modello {{xpp3-extended-writer}} in 
https://github.com/codehaus-plexus/modello/tree/xpp3-extended-writer
integrated in maven-help-plugin branch 
https://github.com/apache/maven-help-plugin/tree/MPH-160

works well, with known limitations:
- does not display input location for plugins configuration (information not 
calculated by Maven core when merging DOM objects, not so easy to track...)
- does not display input location for lists of Strings (reports, roles, 
otherArchives, goals, modules)
- does not display input location for lines inherited from [Maven 
super-POM|https://maven.apache.org/ref/current/maven-model-builder/super-pom.html]:
 requires Maven core improvement


was (Author: hboutemy):
initial implementation of Modello {{xpp3-extended-writer}} in 
https://github.com/codehaus-plexus/modello/tree/xpp3-extended-writer
integrated in maven-help-plugin branch 
https://github.com/apache/maven-help-plugin/tree/MPH-160

works well, with known limitations:
- does not display input location for plugins configuration (information not 
calculated by Maven core when merging DOM objects, not so easy to track...)
- does not display input location for lists of Strings (reports, roles, 
otherArchives, goals, modules)
- does not display input location for lines inherited from Maven super-POM: 
requires Maven core improvement

> add source location in comments to effective pom.xml
> ----------------------------------------------------
>
>                 Key: MPH-160
>                 URL: https://issues.apache.org/jira/browse/MPH-160
>             Project: Maven Help Plugin
>          Issue Type: New Feature
>          Components: effective-pom
>    Affects Versions: 3.1.0
>            Reporter: Hervé Boutemy
>            Priority: Major
>
> during in-memory effective pom building (by maven-model-builder), the source 
> location of content is kept in memory: see [Modello documentation on location 
> tracking|https://codehaus-plexus.github.io/modello/location-tracking.html] 
> and MNG-1803 for its integration into Maven model
> adding this information as comment on every line of generated XML would ease 
> tracking for end users (and not only m2e users, who get "Jump to location" 
> hint when editing their pom.xml in Eclipse...)
> This will require a Modello enhancement (see [Modello 
> #28|https://github.com/codehaus-plexus/modello/issues/28]) then integration
> (idea found during Devoxx 2018 Maven BoF, since users were missing ways to 
> diagnose unexpected result in effective pom)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to