belingueres commented on issue #234: [MNG-6572] - use int or long instead of BigIntegers for little numbers in ComparableVersion URL: https://github.com/apache/maven/pull/234#issuecomment-466811295 Changed to regex (though don't know if it is actually more effcient.) For the squashing part I think I will need to create another branch. Is this OK? El dom., 24 de feb. de 2019 a la(s) 06:54, Robert Scholte ( [email protected]) escribió: > I suggested to replace the StringUtils with a regular expression as well, > which should be more efficient rfscholte@6770383 > <https://github.com/rfscholte/maven/commit/67703831aabd971b5ea8313bb6719a6249064677> > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/maven/pull/234#issuecomment-466756211>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/ABjjQmcY7lb9ZcNSMT_j5WDDHmXdMsEzks5vQmFwgaJpZM4aUD6q> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
