[ 
https://issues.apache.org/jira/browse/MJAVADOC-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16787013#comment-16787013
 ] 

Robert Scholte commented on MJAVADOC-584:
-----------------------------------------

One of both methods in 
https://github.com/apache/maven-javadoc-plugin/blob/master/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java#L334-L436
 is responsible. The seconds contains a comment about the changed behavior.
What I hoped to make clear is that the value of excludePackage is *not* a 
regular expression, it is closer to an Ant-pattern. The dots (both old and new) 
are package separators, but it was optional in the old pattern. the value 
between the dots matches exactly with a folder name.
It looks like there are only integration tests, but this deserves a unittests 
too. I don't mind adjusting the evaluation, as long as it makes sense and that 
you can control exclusion of any package.

> excludePackageNames is not working as documented anymore
> --------------------------------------------------------
>
>                 Key: MJAVADOC-584
>                 URL: https://issues.apache.org/jira/browse/MJAVADOC-584
>             Project: Maven Javadoc Plugin
>          Issue Type: Bug
>    Affects Versions: 3.1.0
>            Reporter: Thomas Mortagne
>            Priority: Minor
>
> We have the following configuration at XWiki: 
> https://github.com/xwiki/xwiki-commons/blob/xwiki-commons-11.1/pom.xml#L1946. 
> We don't want to produce javadoc for internal packages. This is very similar 
> to the example given on 
> https://maven.apache.org/plugins/maven-javadoc-plugin/examples/exclude-package-names.html.
> When I upgrade to 3.1.0 the exclude is not taken into account anymore (I get 
> error related to classes located in internal packages). For example:
> {noformat}
> /home/hudsonagent/jenkins_root/workspace/XWiki_xwiki-commons_master/xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/main/java/org/xwiki/extension/version/internal/DefaultVersionConstraint.java:49:
>  error: reference not found
>  * @see org.sonatype.aether.util.version.GenericVersionConstraint
> {noformat}
> I noticed MJAVADOC-548 but since the documentation did not changed I assumed 
> my use case was still OK.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to