[ http://jira.codehaus.org/browse/MNG-2066?page=comments#action_81236 ] 
            
Thomas Recloux commented on MNG-2066:
-------------------------------------

Thanks for your comments 

> patches have to be against trunk

Does this mean this patch can't be integrated until 2.1 ?

> public api can't be modified, we need to keep backwards compatibility

You are speaking of the Settings object ? In this case, can I had a 
"java.util.List getActiveProxies()" method and keep the "Proxy 
getActiveProxy()" ? Should I mark it has deprecated ?

> need documentation, for instance that setting http proxy will affect https 
> requests

Where should I document it ? In this guide : 
http://maven.apache.org/guides/mini/guide-proxies.html ?

> unit tests would be great

OK

> Specify multiple proxies
> ------------------------
>
>                 Key: MNG-2066
>                 URL: http://jira.codehaus.org/browse/MNG-2066
>             Project: Maven 2
>          Issue Type: Improvement
>    Affects Versions: 2.0.2
>            Reporter: Thomas Recloux
>             Fix For: 2.1
>
>         Attachments: multiple-proxies-paches.zip
>
>
> After this discussion :
> http://www.mail-archive.com/dev@maven.apache.org/msg53099.html
> In the attached zip file, you'll find four patch files :
> - on the maven-artifact-manager projet : changes in the DefaultWagonManager 
> class, using the http proxy when no https proxy is specified.
> - on the maven-core project : changes in the DefaultMaven, adding all teh 
> active proxies from the settings to the wagon manager
> - on the maven-settings project : changes in the settings.mdo file
> Theses patches are built on the maven-2.0.x branch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to