rfscholte commented on a change in pull request #17: [MSHADE-313] - Keep
Services
URL: https://github.com/apache/maven-shade-plugin/pull/17#discussion_r271490554
##########
File path:
src/main/java/org/apache/maven/plugins/shade/filter/MinijarFilter.java
##########
@@ -138,13 +140,19 @@ private void removeServices( final MavenProject project,
final Clazzpath cp )
}
try ( final BufferedReader bufferedReader =
- new BufferedReader( new InputStreamReader(
jar.getInputStream( jarEntry ) ) ) )
+ new BufferedReader( new InputStreamReader(
jar.getInputStream( jarEntry ), UTF_8 ) ) )
{
for ( String className =
bufferedReader.readLine(); className != null;
className = bufferedReader.readLine() )
{
- log.info( className + " was not removed because
it is a service" );
- removeClass( cp , className );
+ className = className.split( "#", 2
)[0].trim();
Review comment:
Okay, from
[ServiceLoader](https://docs.oracle.com/javase/6/docs/api/java/util/ServiceLoader.html)
> This file contains the single line:
>
> com.example.impl.StandardCodecs # Standard codecs
So let's add a test for that too, just ensure nobody removes this piece of
code in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
