eolivelli commented on issue #5: [MCHECKSTYLE-353] - Don't resolve any dependencies URL: https://github.com/apache/maven-checkstyle-plugin/pull/5#issuecomment-480270131 @zregvart thank you, I see your case. As we are breaking compatibility in 3.1.0 for Java version, I am leaning toward accepting your patch. but: - we have to enhance documentation and explain how it works since new 3.1.0 version - we have to be sure with an integration test that it is possible to provide checkstyle configuration using the classpath using a module of the same reactor Like this layout: Reactor: - module "checkstyle-configuration" - module "application" (without an explicit "dependency" to "checkstyle-configuration") in "application" I want to use module "checkstyle-configuration" as checkstyle configuration, so I will have to declare it as dependency of the checkstyle plugin explicitly. This configuration must work: - with a brand new repository (no previous "install" of "checkstyle-configuration" in the local repository) - with parallel builds (-T option) - without the "install phase", like "mvn verify" - ???? other edge cases I also need approval from another committer because this change is an important break and it won't be super easy for existing users to migrate cc @rfscholte @hboutemy @khmarbaise @olamy
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
