rnveach commented on a change in pull request #13: MCHECKSTYLE-366 Upgrade
checkstyle to a more recent version
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/13#discussion_r277182127
##########
File path: src/it/MCHECKSTYLE-129/pom.xml
##########
@@ -57,7 +57,7 @@ under the License.
<artifactId>maven-checkstyle-plugin</artifactId>
<version>${checkstyleVersion}</version>
<configuration>
-
<configLocation>http://svn.apache.org/repos/asf/maven/plugins/tags/maven-checkstyle-plugin-2.15/src/main/resources/config/sun_checks.xml</configLocation>
+
<configLocation>https://raw.githubusercontent.com/checkstyle/checkstyle/master/src/main/resources/sun_checks.xml</configLocation>
Review comment:
I don't recommend using master as it is the development line of the
configuration. If we add a breaking compatibility in it, your release version
of checkstyle could fail.
You should stick to a tag or release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
