rfscholte commented on a change in pull request #28: MRELEASE-985 Override
snapshot dependencies from command line
URL: https://github.com/apache/maven-release/pull/28#discussion_r282136445
##########
File path:
maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java
##########
@@ -108,22 +108,42 @@ private void prepare( ReleasePrepareRequest
prepareRequest, ReleaseResult result
// Create a config containing values from the session properties (ie
command line properties with cli).
ReleaseUtils.copyPropertiesToReleaseDescriptor(
prepareRequest.getUserProperties(),
- new ReleaseDescriptorBuilder()
- {
- public ReleaseDescriptorBuilder
addDevelopmentVersion( String key,
-
String value )
- {
- builder.addDevelopmentVersion(
key, value );
- return this;
- }
-
- public ReleaseDescriptorBuilder
addReleaseVersion( String key,
-
String value )
- {
- builder.addReleaseVersion(
key, value );
- return this;
- };
- } );
+ new ReleaseDescriptorBuilder()
+ {
+ public ReleaseDescriptorBuilder addDevelopmentVersion(
String key,
+
String value )
+ {
+ builder.addDevelopmentVersion( key, value );
+ return this;
+ }
+
+ public ReleaseDescriptorBuilder addReleaseVersion( String
key,
+ String
value )
+ {
+ builder.addReleaseVersion( key, value );
+ return this;
+ }
+
+ public ReleaseDescriptorBuilder
addDependencyOriginalVersion( String dependencyKey, String version )
Review comment:
I think we should let the plugin fill the original versions based on the pom
file, I don't want to know what will happen when somebody overwrites this ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
