michael-o commented on a change in pull request #34: [MRESOLVER-88] Use Java 7
features and style fixes
URL: https://github.com/apache/maven-resolver/pull/34#discussion_r283019420
##########
File path:
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/PartialFile.java
##########
@@ -292,7 +282,8 @@ public PartialFile newInstance( File dstFile,
RemoteAccessChecker checker )
catch ( IOException e )
{
lockFile.close();
- LOGGER.debug( "Cannot create resumable file {}: {}",
partFile.getAbsolutePath(), e.getMessage(), e );
+ LOGGER.debug( "Cannot create resumable file {}: {}",
partFile.getAbsolutePath(), e.getMessage(),
Review comment:
I think the `e.getMessage()` is redundant if you pass the exception anyway.
This bad habit spreads througout the entire codebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
