Tibor17 commented on a change in pull request #226: Extended SimpleReportEntry
with sourceText and nameText
URL: https://github.com/apache/maven-surefire/pull/226#discussion_r286156602
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/StartupReportConfiguration.java
##########
@@ -107,8 +119,11 @@ public StartupReportConfiguration( boolean useFile,
boolean printSummary, String
this.rerunFailingTestsCount = rerunFailingTestsCount;
this.xsdSchemaLocation = xsdSchemaLocation;
String charset = trimToNull( encoding );
- this.encoding = charset == null ? Charset.defaultCharset() :
Charset.forName( charset );
+ this.encoding = charset == null ? UTF_8 : Charset.forName( charset );
Review comment:
We have to find the Jira issue because this is what the users wanted. They
expected wider charset or the same as it was in forked JVM. The problem is that
two JVMs (Maven and forked) may have two different charsets. It was a problem
that 8 bit charsets are not compatible. Due to we transfer all strings over the
pipes via UTF-8 (SUREFIRE-1222), we should not use shorter charset for `charset
= null`. This is one point where both SUREFIRE-1222 and SUREFIRE1546 are
touched.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
