Tibor17 edited a comment on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496030290
 
 
   @pzygielo 
   Regarding L240 and 244, iterates over all public methods and discovers 
certain methods.
   After discovery mechanism has completed, the test methods are executed with 
setUp and tearDown methods around.
   If it is bug, then it is because the developers did not write complete 
integration test in 2006. But it does not mean that setUp and tearDown methods 
have to be static. The documentation clearly says that these methods are caled 
around test method, and for every test method, and the example shows that ther 
are instance methods. Exactly like it is in JUnit library. So there is no issue 
in documentation and it does not mean that documentation has to be changed. 
Oposite has to happen and the code has to be fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to