minfrin commented on a change in pull request #5: Switch from XhtmlSink to
Xhtml5Sink as the default site renderer.
URL:
https://github.com/apache/maven-doxia-sitetools/pull/5#discussion_r288341343
##########
File path:
doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/AptVerifier.java
##########
@@ -59,8 +60,8 @@ public void verify( String file )
//
//
----------------------------------------------------------------------
- HtmlDivision div = (HtmlDivision) elementIterator.next();
- assertEquals( "section", div.getAttribute( "class" ) );
+ /* cannot use HtmlSection until
https://sourceforge.net/p/htmlunit/bugs/1961/ is fixed */
Review comment:
I see that https://sourceforge.net/p/htmlunit/bugs/1961/ was closed roughly
24 hours ago, so tried to give a go upgrading to the latest httpunit.
This is the point I got stuck with the enforcer plugin telling me that doxia
contains 1.7 bytecode, so I came to a screeching halt.
It has jogged a memory - as I recall I tried upgrading htmlunit when I
encountered the above bug, and versions of htmlunit newer that v2.16 from 2015
require java7+, which is failed by maven's enforcer config.
I don't think this can be fixed until maven releases a new parent POM
supporting a minimum of java8. Let me raise a jira ticket for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
