[
https://issues.apache.org/jira/browse/MJLINK-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16860184#comment-16860184
]
Roberto Araujo commented on MJLINK-6:
-------------------------------------
Tested and is working fine. Tested in Linux (Travis CI) and macOS (my machine)
with Java 9, 10, 11 and 12
My suggestion is also to include an WARN log when the `sourceJdkModules` folder
is invalid. Note that in case we use an invalid folder we will fallback to the
folder based on `jlink` binary location and the user will not notice the
problem. (happened to me)
Example project with success use:
[https://github.com/andrioli/maven-jlink-docker-example]
Thanks
> Allow set the jmods path
> ------------------------
>
> Key: MJLINK-6
> URL: https://issues.apache.org/jira/browse/MJLINK-6
> Project: Maven JLink Plugin
> Issue Type: Improvement
> Reporter: Roberto Araujo
> Assignee: Robert Scholte
> Priority: Minor
> Labels: up-for-grabs
> Fix For: 3.0.0-alpha-2
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The current version of the plugin hard-coded the `jmods` folder (based on
> `jlink` binary location). But, for instance, if I want to build a runtime
> image for Linux running the build in a OSX the runtime image will not be
> compatible.
> I suggest to allow users define the JDK `jmods` folder, and if nothing is
> set, use the one based on the JAVA_HOME/Toolchain configuration.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
