behrangsa commented on a change in pull request #3: Enabled generating Java 9+ projects as well as using JUnit 5.x URL: https://github.com/apache/maven-archetypes/pull/3#discussion_r294075379
########## File path: maven-archetype-quickstart/src/test/resources/projects/it-java-11-junit-5.4.2/reference/pom.xml ########## @@ -0,0 +1,82 @@ +<?xml version="1.0" encoding="UTF-8"?> + + + +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <groupId>archetype.it</groupId> + <artifactId>java-11-junit-542-quickstart</artifactId> + <version>0.1-SNAPSHOT</version> + + <name>java-11-junit-542-quickstart</name> + <!-- FIXME change it to the project's website --> + <url>http://www.example.com</url> + + <properties> + <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> + <maven.compiler.release>11</maven.compiler.release> + </properties> + + <dependencies> + <dependency> Review comment: Fixed in 61fd053. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
