michael-o commented on a change in pull request #10: Resolve XHTML5 compatibility issues highlighted by https://validator.… URL: https://github.com/apache/maven-fluido-skin/pull/10#discussion_r295793010
########## File path: src/main/resources/META-INF/maven/site.vm ########## @@ -28,10 +28,10 @@ | Rendered using Apache Maven Fluido Skin @project.version@ --> ## -<html xmlns="http://www.w3.org/1999/xhtml"#if ( $locale ) xml:lang="$locale.language" lang="$locale.language"#end> Review comment: I am not certain about `xml:id` but dropping the namespace seems wrong. See [here](https://stackoverflow.com/a/34407786/696632) and [here](https://github.com/whatwg/html/blob/master/FAQ.md#what-is-the-namespace-declaration). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
