belingueres commented on a change in pull request #38: [MENFORCER-313] - Added [<scope>] to the conflicting artifacts in the output. Highlight those with compile scope. URL: https://github.com/apache/maven-enforcer/pull/38#discussion_r297271569
########## File path: maven-enforcer-plugin/src/it/projects/require-upper-bound-dependencies-managed_failure/verify.groovy ########## @@ -21,9 +21,9 @@ File buildLog = new File( basedir, 'build.log' ) assert buildLog.text.contains( 'Rule 0: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:' ) def message = 'Failed while enforcing RequireUpperBoundDeps. The error(s) are [' + LS+ -'Require upper bound dependencies error for org.apache.maven.plugins.enforcer.its:menforcer146-x:1.1 paths to dependency are:' + LS+ +'Require upper bound dependencies error for org.apache.maven.plugins.enforcer.its:menforcer146-x:1.1 [compile] paths to dependency are:' + LS+ Review comment: Yes, adding the scope there it does look out of place. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
