michael-o commented on a change in pull request #268: [MNG-6702] Improve
DefaultModelValidator speed
URL: https://github.com/apache/maven/pull/268#discussion_r300881024
##########
File path:
maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java
##########
@@ -184,32 +184,32 @@ public void validateRawModel( Model m,
ModelBuildingRequest request, ModelProble
}
validate30RawProfileActivation( problems,
profile.getActivation(), profile.getId(),
- prefix + ".activation",
request );
+ prefix, ".activation", request
);
Review comment:
I wonder whether we should not drop the leading dot here and add it in the
method only. This makes it consistent with the rest which does not use leading
dots for premature concat. Or actually the prefix should contain the dot
because it is a *prefix*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
