[
https://issues.apache.org/jira/browse/MDEP-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16893093#comment-16893093
]
Pim Moerenhout edited comment on MDEP-653 at 7/26/19 5:59 AM:
--------------------------------------------------------------
Hi Hervé,
Thanks! Some questions:
1) Does it make sense to print out an empty expression, like:
getLog().debug( "Skipping empty gav pattern: " + gavPattern );
Maybe better is:
getLog().debug( "Skipping empty gav pattern" );
2) Should the following messages not be displayed by default ? Now they only
display if verbose
Purging artifact: com.fasterxml.jackson.core:jackson-databind:jar:2.3.0
Deleting:
/Users/pim/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.3.0
3) For the Multi-Module, I want to use: Is this a clear message for the user ?
Message for purging local directory now includes the project.getId and the
singular/plural form of dependency:
Deleting 1 direct dependency for project
net.moerenhout:module2:jar:1.0-SNAPSHOT from /Users/pim/.m2/repository with
artifact version resolution fuzziness
Regards, Pim
was (Author: pmoerenhout):
Hi Hervé,
Thanks! Some questions:
1) Does it make sense to print out an empty expression, like:
getLog().debug( "Skipping empty gav pattern: " + gavPattern );
Maybe better is:
getLog().debug( "Skipping empty gav pattern" );
2) Should the following messages not be displayed by default ? Now they only
display if verbose
Purging artifact: com.fasterxml.jackson.core:jackson-databind:jar:2.3.0
Deleting:
/Users/pim/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.3.0
3) For the Multi-Module, I want to use: Is this a clear message for the user ?
Message for purging local directory now includes the project.getId and the
singular/plural form of dependency:
Deleting 1 direct dependency for project
net.moerenhout:module2:jar:1.0-SNAPSHOT from /Users/pim/.m2/repository with
artifact version resolution fuzziness
I also noticed that on my system, the TestUnpackMojo fails sometimes at line
572:
assertTrue( "unpackedFile '" + unpackedFile + "' lastModified() == " +
marker.lastModified()
+ ": should be different", marker.lastModified() !=
unpackedFile.lastModified() );
I want to increase the timers, like:
// go back 12 more seconds for linux
time -= 12000;
// set to known value
assertTrue( unpackedFile.setLastModified( time ) );
// set source to be newer was 4s but test is brittle on MacOS if less
than 6s
assertTrue( artifact.getFile().setLastModified( time + 6000 ) );
Regards, Pim
> add info message to purge-local-repository goal even in non-verbose mode
> ------------------------------------------------------------------------
>
> Key: MDEP-653
> URL: https://issues.apache.org/jira/browse/MDEP-653
> Project: Maven Dependency Plugin
> Issue Type: Improvement
> Components: purge-local-repository
> Affects Versions: 3.1.1
> Reporter: Hervé Boutemy
> Assignee: Hervé Boutemy
> Priority: Major
> Labels: up-for-grabs
> Fix For: 3.1.2
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> currently, there is no info message apart from download status while
> re-resolving (or in verbose mode, there is too much output):
> {noformat}
> $ mvn dependency:purge-local-repository
> [INFO] Scanning for projects...
> [INFO]
> [INFO] ----------< org.apache.maven.plugins:maven-dependency-plugin
> >----------
> [INFO] Building Apache Maven Dependency Plugin 3.1.2-SNAPSHOT
> [INFO] ----------------------------[ maven-plugin
> ]----------------------------
> [INFO]
> [INFO] --- maven-dependency-plugin:3.1.1:purge-local-repository (default-cli)
> @ maven-dependency-plugin ---
> Downloading from central:
> http://localhost:8081/nexus/content/groups/public/org/apache/maven/maven-artifact/3.0/maven-artifact-3.0.pom
> Downloaded from central:
> http://localhost:8081/nexus/content/groups/public/org/apache/maven/maven-artifact/3.0/maven-artifact-3.0.pom
> (1.9 kB at 29 kB/s)
> [...]
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO]
> ------------------------------------------------------------------------{noformat}
> would be useful to write something like:
> {noformat}
> [INFO] Deleting 75 projects' transitive dependencies from
> /home/herve/.m2/repository at artifact version level
> [INFO] Re-resolving dependencies
> Downloading from central:
> http://localhost:8081/nexus/content/groups/public/org/apache/maven/maven-artifact/3.0/maven-artifact-3.0.pom
> Downloaded from central:
> http://localhost:8081/nexus/content/groups/public/org/apache/maven/maven-artifact/3.0/maven-artifact-3.0.pom
> (1.9 kB at 29 kB/s)
> [...]{noformat}
> with bold color for configurable arguments (count, "transitive" vs "direct",
> "version" or other fuzzyness values)
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
