Tibor17 commented on a change in pull request #46: [MNG-6731] Jetty 
getLocalPort() returns -1 resulting in build failures
URL: 
https://github.com/apache/maven-integration-testing/pull/46#discussion_r314302466
 
 

 ##########
 File path: 
core-it-suite/src/test/java/org/apache/maven/it/MavenIT0146InstallerSnapshotNaming.java
 ##########
 @@ -59,15 +60,11 @@ protected void setUp()
         server = new Server( 0 );
         server.setHandler( handlers );
         server.start();
-        while ( !server.isRunning() || !server.isStarted() )
+        if ( server.isFailed() )
         {
-            if ( server.isFailed() )
-            {
-                fail( "Couldn't bind the server socket to a free port!" );
-            }
-            Thread.sleep( 100L );
+            fail( "Couldn't bind the server socket to a free port!" );
         }
-        port = server.getConnectors()[0].getLocalPort();
+        port = ( (NetworkConnector) server.getConnectors()[0] ).getLocalPort();
 
 Review comment:
   We can improve as always but I spent 3 days with these 38 tests and for me 
it is always good to have several smaller changes than one big change. With 
small changes/commits we can always test older commits if we find some issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to