Tibor17 commented on a change in pull request #39: [MRESOLVER-93] -
PathRecordingDependencyVisitor to handle 3 cycles
URL: https://github.com/apache/maven-resolver/pull/39#discussion_r316127591
##########
File path:
maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/visitor/PathRecordingDependencyVisitor.java
##########
@@ -101,6 +96,7 @@ public boolean visitEnter( DependencyNode node )
{
boolean accept = filter == null || filter.accept( node, parents );
+ boolean hasDuplicateNodeInParent = parents.contains( node );
Review comment:
The limitation of this impl is the identity-base in the `Map` but the
`DefaultDependencyNode` does not have `equals` method, so ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
