rfscholte commented on issue #281: [MNG-6357] Dependency order should be 
nearest first
URL: https://github.com/apache/maven/pull/281#issuecomment-526841366
 
 
   Looks good at first sight. This code deserves a unittest, that's better than 
relying on plugins. I don't think the unittest is too hard to write.
   I noticed you're not using diamond operators. Looking at the code it should 
be written with the new Map methods, but that requires Java 8. The moment that 
Maven will require Java 8 is getting closer

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to