Tibor17 commented on a change in pull request #17: Do not throw exception in
finally block
URL: https://github.com/apache/maven-plugin-tools/pull/17#discussion_r319730720
##########
File path:
maven-plugin-tools-generators/src/main/resources/help-class-source.vm
##########
@@ -144,7 +144,7 @@ public class HelpMojo
}
catch ( IOException e )
{
- throw new MojoExecutionException( e.getMessage(), e );
+ getLog().warn( "Could not close " + PLUGIN_HELP_PATH + ":
" + e.getMessage() );
Review comment:
It perfectly fits to our goals. ;-)
We set the Javac version 1.7 and we were updating the code to J7.
Later we will do the same for J8 - inner classes/Lambda, I/O, loops with
method chaining, use of the class `Optional`, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
