rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base
for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r330204200
##########
File path:
maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
##########
@@ -733,12 +758,81 @@ private void checkPluginVersions( List<ModelData>
lineage, ModelBuildingRequest
private void assembleInheritance( List<ModelData> lineage,
ModelBuildingRequest request,
ModelProblemCollector problems )
{
- for ( int i = lineage.size() - 2; i >= 0; i-- )
+ for ( int i = lineage.size() - 2; i >= 1; i-- )
Review comment:
The next fragment in crucial. `lineage` contains the list of (inherited)
parents poms + current pom, where a parent is already transformed (when it was
a child). Based on the flag it decides if the child/current pom should be
transformed or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
