Tibor17 commented on issue #286: [MNG-6656] Introduce base for build/consumer 
process
URL: https://github.com/apache/maven/pull/286#issuecomment-537206583
 
 
   @rfscholte 
   I found this in the emails. You should not throw RuntimeException in 
`DefaultModelBuilder`. It is bad practice and seen few more times in the Maven. 
You should find better subclass e.g. `IllegalStateException` or create a new 
exception class or use `Callable` instead of `Runnable`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to