eolivelli commented on a change in pull request #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#discussion_r330296309
########## File path: maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java ########## @@ -238,9 +263,83 @@ else if ( request.isUpdateSnapshots() ) mavenRepositorySystem.injectProxy( session, request.getPluginArtifactRepositories() ); mavenRepositorySystem.injectAuthentication( session, request.getPluginArtifactRepositories() ); + if ( Boolean.getBoolean( "maven.experimental.buildconsumer" ) ) + { + session.setFileTransformerManager( newFileTransformerManager() ); + } return session; } + private FileTransformerManager newFileTransformerManager() + { + return new FileTransformerManager() + { + @Override + public Collection<FileTransformer> getTransformersForArtifact( final Artifact artifact ) + { + Collection<FileTransformer> transformers = new ArrayList<>(); + if ( "pom".equals( artifact.getExtension() ) ) + { + final TransformerFactory transformerFactory = TransformerFactory.newInstance(); + + transformers.add( new FileTransformer() + { + @Override + public InputStream transformData( File file ) + throws IOException, TransformException + { + final PipedOutputStream pipedOutputStream = new PipedOutputStream(); + final PipedInputStream pipedInputStream = new PipedInputStream( pipedOutputStream ); + + final SAXSource transformSource; + try + { + transformSource = + new SAXSource( consumerPomXMLFilterFactory.get().get( file.toPath() ), + new InputSource( new FileReader( file ) ) ); + } + catch ( SAXException | ParserConfigurationException e ) + { + e.printStackTrace(); + throw new TransformException( "Failed to create a consumerPomXMLFilter", e ); + } + + final StreamResult result = new StreamResult( pipedOutputStream ); + + final Runnable runnable = new Runnable() + { + @Override + public void run() + { + try ( PipedOutputStream out = pipedOutputStream ) + { + transformerFactory.newTransformer().transform( transformSource, result ); + } + catch ( TransformerException | IOException e ) + { + e.printStackTrace(); + throw new RuntimeException( e ); + } + } + }; + + new Thread( runnable ).start(); Review comment: maybe it is better to give a name to this thread and consider make it a daemon thread. I don't know if it is worth to use a thread pool, in order to save the creation/destruction of a thread for each pom to transform ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services