Col-E commented on a change in pull request #245: Surefire-1584: Add option to
rerun failing tests for JUnit5
URL: https://github.com/apache/maven-surefire/pull/245#discussion_r330330659
##########
File path:
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java
##########
@@ -47,6 +47,7 @@
implements TestExecutionListener
{
private final ConcurrentMap<TestIdentifier, Long> testStartTime = new
ConcurrentHashMap<>();
+ private final ConcurrentMap<TestIdentifier, TestExecutionResult> failures
= new ConcurrentHashMap<>();
Review comment:
Perhaps associating a test context to the failures would be a sensible
solution here.
If the `failures` cannot be cleared in `testPlanExecutionFinished` due to
them being needed in `JUnitPlatformProvider#invokeAllTests`, how should they be
cleared? If done externally by the providers even the providers that don't need
the `failures` collection would need to clear them. Any ideas?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
