[
https://issues.apache.org/jira/browse/MSHARED-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948227#comment-16948227
]
Herve Boutemy commented on MSHARED-837:
---------------------------------------
no, I didn't have time until now: you know, it's my free time
for
https://github.com/apache/maven-archiver/commit/2f45473f180cbd1fdc2b828095e2f0e57d077a0e,
you transform X to XXX without proving anything about the impact: I don't know
why XXX is better than X, nor what it means
for
https://github.com/apache/maven-archiver/commit/9e7cc4daf109b8970ae6517ac6d4c132ec942b14
, you add a new dependency and tell me that it is better because it fails a
unit test, that makes me think it removes some supported formats for setting a
timestamp
I don't see why I would not simply rely on JDK's DateFormat X: it works, is
easy to use, easy to understand for users.
> add an API to configure Reproducible Builds with outputTimestamp
> ----------------------------------------------------------------
>
> Key: MSHARED-837
> URL: https://issues.apache.org/jira/browse/MSHARED-837
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-archiver
> Affects Versions: maven-archiver-3.4.0
> Reporter: Herve Boutemy
> Assignee: Herve Boutemy
> Priority: Major
> Fix For: maven-archiver-3.4.1
>
>
> creating an archive in a Reproducible Builds way requires to configure
> archiver with an output timestamp: see
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=74682318
> The timestamp value can't be natively injected as Date with Plexus, because
> Plexus Date injection uses local timezone, then is not reproducible: see
> https://codehaus-plexus.github.io/plexus-containers/plexus-container-default/xref/org/codehaus/plexus/component/configurator/converters/basic/DateConverter.html
> Then we need top inject ${project.build.outputTimestamp} as a String and
> provide an API to parse this String to a Date, before calling
> plexus-archiver's configureReproducible
> https://github.com/codehaus-plexus/plexus-archiver/pull/121
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
