michael-o commented on a change in pull request #57: WAGON-567: support retry
on server side errors
URL: https://github.com/apache/maven-wagon/pull/57#discussion_r335445557
##########
File path:
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/StandardServiceUnavailableRetryStrategy.java
##########
@@ -28,17 +28,13 @@
import org.apache.http.util.Args;
/**
- * An implementation of the {@link SimpleServiceUnavailableRetryStrategy}
interface.
+ * An implementation of the {@link ServiceUnavailableRetryStrategy} interface.
* that retries {@code 408} (Request Timeout), {@code 420} (Method Failure),
{@code 429} (Too Many Requests),
* and {@code 500} (Server side error) responses for a fixed number of times
at a fixed interval.
*/
@Contract( threading = ThreadingBehavior.IMMUTABLE )
-public class SimpleServiceUnavailableRetryStrategy implements
ServiceUnavailableRetryStrategy
+public class StandardServiceUnavailableRetryStrategy implements
ServiceUnavailableRetryStrategy
Review comment:
I am not convinced that this should be really called standard because of >=
500 and there seems to many intepretations of 420 and all of them are
deprecated or not present:
https://www.whoishostingthis.com/resources/http-status-codes/#method-failure-400.
I am fine with 408, 421, 503 and 504.
Please tell me why all 5xy are necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
