Col-E commented on issue #245: Surefire-1584: Add option to rerun failing tests 
for JUnit5 
URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-544641900
 
 
   This is actually a **one character** fix :man_facepalming: 
   
   [JUnitPlatformProvider - Line 
195](https://github.com/apache/maven-surefire/blob/d0230dcc93e6cd1b8171407237489fdf291cca48/surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java#L195)
   
   When writing `buildLauncherDiscoveryRequestForRerunFailures` I called 
`String[] toClassMethodNameWithoutPlan()` to fetch the method name `source[3]`, 
but should be using `source[2]` instead.
   
   * `source[3]` is the resolved method name _(Which uses `@DisplayName`'s 
value)_
   
   * `source[2]` is the actual method name.
   
   Changing `3` to `2` is all that is necessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to