eolivelli commented on a change in pull request #297: MNG-6771 Fix license
issues on binary distribution
URL: https://github.com/apache/maven/pull/297#discussion_r339316904
##########
File path: apache-maven/src/main/assembly/component.xml
##########
@@ -29,6 +29,7 @@ under the License.
<dependencySet>
<useProjectArtifact>false</useProjectArtifact>
<outputDirectory>lib</outputDirectory>
+
<outputFileNameMapping>${artifact.artifactId}-${artifact.version}.${artifact.extension}</outputFileNameMapping>
Review comment:
This is to have a cleaner and consistent naming of jars in LICENSE file and
in 'lib' directory.
We should add 'classifier' in both or drop it in both, actually it seems
simpler to do drop
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
