michael-o commented on a change in pull request #298: [MNG-6797] - Remember if 
Maven model problems were encountered.
URL: https://github.com/apache/maven/pull/298#discussion_r341805516
 
 

 ##########
 File path: 
maven-core/src/main/java/org/apache/maven/execution/MavenSession.java
 ##########
 @@ -262,6 +264,18 @@ public void setParallel( boolean parallel )
         this.parallel = parallel;
     }
 
+    /**
+     * This indicates whether there were any problems detected when building 
Maven model.
+     * @return true if there were problems, false otherwise
+     */
+    public boolean isProblems() {
 
 Review comment:
   That really hurts because the plural implies that you have a collection of 
problem, and not a boolean value. Moreover, third person singular with a plural 
reads horribly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to