Tibor17 commented on a change in pull request #248: SUREFIRE-1695 Support
multiple inheritance of @Categories
URL: https://github.com/apache/maven-surefire/pull/248#discussion_r348752650
##########
File path:
surefire-providers/common-junit48/src/main/java/org/apache/maven/surefire/common/junit48/GroupMatcherCategoryFilter.java
##########
@@ -173,6 +176,11 @@ private boolean shouldRun( Description description,
Description parent, Class<?>
}
}
+ private static boolean categoryIsInherited()
Review comment:
IMO this `boolean` value never change, so it makes sense to cache it in the
`private static final` field. It is also important due to the method
`isAnnotationPresent` is implemented as calling reflection and creation of a
new instance. This might be visible execution time in loops.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
