[
https://issues.apache.org/jira/browse/MANTRUN-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980739#comment-16980739
]
Herve Boutemy commented on MANTRUN-221:
---------------------------------------
thanks for pinging: many places to watch for interesting contributions
can you provide a sample failure in an IT that the code change fixes, please?
for example an update in the MANTRUN-178 IT that proves that something is
missing (I still did not understand what) that the update in the plugins code
fixes?
I also unzipped your mwe.zip sqample, but don't know what command to run, what
is the expected vs actual result: please write down, so I really understand
what this is about
> Fails to pass maven properties set in user properties only
> ----------------------------------------------------------
>
> Key: MANTRUN-221
> URL: https://issues.apache.org/jira/browse/MANTRUN-221
> Project: Maven Antrun Plugin
> Issue Type: Bug
> Affects Versions: 1.8
> Reporter: Alex Szczuczko
> Priority: Major
> Attachments: mwe.zip
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A user of mine [reported a
> problem|https://github.com/ASzc/jsonpath-maven-plugin/issues/3] between
> jsonpath-maven-plugin:set-properties and maven-antrun-plugin:run. My analysis
> points to a bug in maven-antrun-plugin, introduced in version 1.8 by
> MANTRUN-178.
> MANTRUN-178 incorrectly assumes in AntRunMojo#copyProperties() that all
> properties will be present in mavenProject.getProperties(), and so fails to
> copy properties set at runtime in session.getUserProperties().
> I've attached a MWE, showing maven-help-plugin:evaluate seeing the property
> set by jsonpath-maven-plugin:set-properties, and maven-antrun-plugin:run
> failing to see the same property.
> I intend to file a PR to fix this shortly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)