t-8ch commented on issue #257: [SUREFIRE-1727] junitplatform: handle all 
containers
URL: https://github.com/apache/maven-surefire/pull/257#issuecomment-559421094
 
 
   @Tibor17 
   
   > We have a similar issue 
[SUREFIRE-1688](https://issues.apache.org/jira/browse/SUREFIRE-1688) which 
happens when the method annotated by `@BeforeAll` throws an exception.
   
   It looks mostly the same, only that for my issue the source of the container 
is a MethodSource while there it is a ClassSource.
   
   > IMO the fix should be placed at the 
[line](https://github.com/apache/maven-surefire/blob/master/surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java#L121)
   
   This would not work for my case, as it is neither a class nor a test.
   This line should not be reached because the failed entity is only a 
container and not a test

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to