[ 
https://issues.apache.org/jira/browse/MNG-5986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003716#comment-17003716
 ] 

Robert Scholte commented on MNG-5986:
-------------------------------------

True, internally configuration and all its sub-elemements are XPP3Dom 
instances, all aware of these magic attributes.
However, I don't think there's a real usecase where these attributes on the 
roottag are useful, but I might be wrong.
And even if we fix this, there are more attributres in play, not just 
combine.self.

Regarding changing scheme's, we've added some attributes in the past. Even such 
small innocent changes turned out to be quite problematic, so I'd prefer to 
keep it as it is.




> XML validators flag errors on poms that declare plugin configurations using 
> the 'combine.self' attribute because the maven-4.0.0 XSD does not declare 
> this attribute.
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MNG-5986
>                 URL: https://issues.apache.org/jira/browse/MNG-5986
>             Project: Maven
>          Issue Type: Bug
>          Components: POM
>    Affects Versions: 3.3.3
>         Environment: All
>            Reporter: Ben Tels
>            Priority: Minor
>
> Maven recognizes an attribute 'combine.self' on the 'configuration' element 
> within plugin declarations within a POM ('configuration' elements within and 
> outside 'execution' elements). However, an XML validator flags use of this 
> attribute as an error. Which is correct, because published XSD 
> http://maven.apache.org/xsd/maven-4.0.0.xsd does not declare 'combine.self' 
> as an attribute of 'configuration'.
> Current declaration of the configuration element:
> {code:xml}
>       <xs:element name="configuration" minOccurs="0">
>         <xs:annotation>
>           <xs:documentation source="version">4.0.0</xs:documentation>
>           <xs:documentation source="description">The configuration of the 
> reporting plugin.</xs:documentation>
>         </xs:annotation>
>         <xs:complexType>
>           <xs:sequence>
>             <xs:any minOccurs="0" maxOccurs="unbounded" 
> processContents="skip"/>
>           </xs:sequence>
>         </xs:complexType>
>       </xs:element>{code}
> Simple fix:
> {code:xml}
>       <xs:element name="configuration" minOccurs="0">
>         <xs:annotation>
>           <xs:documentation source="version">0.0.0+</xs:documentation>
>         </xs:annotation>
>         <xs:complexType>
>           <xs:sequence>
>             <xs:any minOccurs="0" maxOccurs="unbounded" 
> processContents="skip"/>
>           </xs:sequence>
>           <xs:attribute name="combine.self" type="xs:string" use="optional"/>
>         </xs:complexType>
>       </xs:element>{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to