[
https://issues.apache.org/jira/browse/MCHECKSTYLE-387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell updated MCHECKSTYLE-387:
-----------------------------------------
Description:
h2. Current situation
In 3.1.1, the PR [https://github.com/apache/maven-checkstyle-plugin/pull/18]
added a {{try-catch}}-block to the to-be-removed method call
{{Checker::setClassLoader}}.
Since users should be encuraged to upgrade and maven-plugin-developers should
know that this method should be removed some time, a warning is to be issued if
the method call was successful (i.e. when not entering the catch block).
h2. Caveat and drawbacks
* Users will have to update their {{checkstyle.xml}} file because of
incompatible changes introduced in {{8.24}}.
* Otherwise the warning might confuse users.
* Once the method call to {{Checker::setClassLoader}} is removed,
{{checkstyle}} versions prior to 8.26 (Source:
[https://checkstyle.org/releasenotes.html#Release_8.26]) cannot be used anymore
(Source:
[https://github.com/checkstyle/checkstyle/commit/145160f5e21b80c27dc93a1904fe33b9afd4f212]
and [https://github.com/checkstyle/checkstyle/issues/3773]). But this issue is
not about removing this method call any time soon.
h2. Related issues
*
[MCHECKSTYLE-381|[https://issues.apache.org/jira/projects/MCHECKSTYLE/issues/MCHECKSTYLE-381]]
The mentioned previous commit.
*
[MCHECKSTYLE-384|[https://issues.apache.org/jira/projects/MCHECKSTYLE/issues/MCHECKSTYLE-384]]:
Once Checkstyle Plugin updates to checkstyle > 8.24, the default installation
will break existing installations unless users use this method of downgrading
their checkstyle version:
[https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html.]
was:
h2. Current situation
In 3.1.1, the PR [https://github.com/apache/maven-checkstyle-plugin/pull/18]
added a {{try-catch}}-block to the to-be-removed method call
{{Checker::setClassLoader}}.
Since users should be encuraged to upgrade and maven-plugin-developers should
know that this method should be removed some time, a warning is to be issued if
the method call was successful (i.e. when not entering the catch block).
h2. Caveat and drawbacks
* Users will have to update their {{checkstyle.xml}} file because of
incompatible changes introduced in {{8.24}}.
* Otherwise the warning might confuse users.
* Once the method call to {{Checker::setClassLoader}} is removed,
{{checkstyle}} versions prior to 8.25 or 8.26 (TBD: look up) cannot be used
anymore (TBD: verify this claim). But this issue is not about removing this
method call any time soon.
h2. Related issues
*
[MCHECKSTYLE-381|[https://issues.apache.org/jira/projects/MCHECKSTYLE/issues/MCHECKSTYLE-381]]
The mentioned previous commit.
*
[MCHECKSTYLE-384|[https://issues.apache.org/jira/projects/MCHECKSTYLE/issues/MCHECKSTYLE-384]]:
Once Checkstyle Plugin updates to checkstyle > 8.24, the default installation
will break existing installations unless users use this method of downgrading
their checkstyle version:
[https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html.]
> Deprecate method setUpCheckstyleClassloader in 3.1.2
> ----------------------------------------------------
>
> Key: MCHECKSTYLE-387
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-387
> Project: Maven Checkstyle Plugin
> Issue Type: Task
> Affects Versions: 3.1.1
> Reporter: Benjamin Marwell
> Priority: Major
>
> h2. Current situation
> In 3.1.1, the PR [https://github.com/apache/maven-checkstyle-plugin/pull/18]
> added a {{try-catch}}-block to the to-be-removed method call
> {{Checker::setClassLoader}}.
> Since users should be encuraged to upgrade and maven-plugin-developers should
> know that this method should be removed some time, a warning is to be issued
> if the method call was successful (i.e. when not entering the catch block).
> h2. Caveat and drawbacks
> * Users will have to update their {{checkstyle.xml}} file because of
> incompatible changes introduced in {{8.24}}.
> * Otherwise the warning might confuse users.
> * Once the method call to {{Checker::setClassLoader}} is removed,
> {{checkstyle}} versions prior to 8.26 (Source:
> [https://checkstyle.org/releasenotes.html#Release_8.26]) cannot be used
> anymore (Source:
> [https://github.com/checkstyle/checkstyle/commit/145160f5e21b80c27dc93a1904fe33b9afd4f212]
> and [https://github.com/checkstyle/checkstyle/issues/3773]). But this issue
> is not about removing this method call any time soon.
> h2. Related issues
> *
> [MCHECKSTYLE-381|[https://issues.apache.org/jira/projects/MCHECKSTYLE/issues/MCHECKSTYLE-381]]
> The mentioned previous commit.
> *
> [MCHECKSTYLE-384|[https://issues.apache.org/jira/projects/MCHECKSTYLE/issues/MCHECKSTYLE-384]]:
> Once Checkstyle Plugin updates to checkstyle > 8.24, the default
> installation will break existing installations unless users use this method
> of downgrading their checkstyle version:
> [https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html.]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
