rfscholte commented on a change in pull request #15: MASSEMBLY-922 - allow to 
override UID/GID for files stored in TAR
URL: 
https://github.com/apache/maven-assembly-plugin/pull/15#discussion_r362097949
 
 

 ##########
 File path: 
src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java
 ##########
 @@ -404,6 +404,32 @@
     @Parameter( defaultValue = "${project.build.outputTimestamp}" )
     private String outputTimestamp;
 
+    /**
+     * Override of user ID in archive type which can store it.
+     */
+    @Parameter( property = "assembly.overrideUid" )
 
 Review comment:
   Is there really a case the you when you need to change it for just one 
build? To me you want a consistent output, so hence not expose the parameter 
not with a property.
   I noticed that the previous developers were quite enthousiastic with 
providing properties, but nowadays we're looking more closely if it really 
makes sense.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to