KroArtem commented on a change in pull request #1: Use new version of site and
thoughts about new release
URL:
https://github.com/apache/maven-verifier-plugin/pull/1#discussion_r365544608
##########
File path: src/main/java/org/apache/maven/plugins/verifier/VerifierMojo.java
##########
@@ -123,17 +122,11 @@ private VerificationResult verify()
{
VerificationResult results = new VerificationResult();
- Reader reader = null;
- try
+ try ( Reader reader = new FileReader( this.verificationFile ) )
Review comment:
Indeed. There are no open issues about it, though, and according to this
answer there is no possibility to set encoding for FileReader until Java 11.
https://stackoverflow.com/questions/696626/java-filereader-encoding-issue
(another way still exists, though)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
