[
https://issues.apache.org/jira/browse/WAGON-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024910#comment-17024910
]
Michael Medin commented on WAGON-576:
-------------------------------------
Yes, given the following code:
{{package medin.name;}}
{{import java.io.IOException;}}
{{import org.apache.http.client.HttpRequestRetryHandler;}}
{{import org.apache.http.protocol.HttpContext;}}
{{public class Test implements HttpRequestRetryHandler {}}
{{ public Test() {}}
{{ System.out.println("--------------------->LOADING");}}
{{ }}}
{{ @Override}}
{{ public boolean retryRequest(IOException e, int i, HttpContext httpContext)
{}}
{{ System.out.println("--------------------->" + e);}}
{{ System.out.println("--------------------->" + i);}}
{{ System.out.println("--------------------->" + httpContext);}}
{{ return false;}}
{{ }}}
{{}}}
I get the following exception:
{{[WARNING] Error injecting:
org.apache.maven.wagon.providers.http.HttpWagon$__sisu21}}
{{java.lang.NoClassDefFoundError:
org/apache/http/client/HttpRequestRetryHandler}}
{{ at java.lang.ClassLoader.defineClass1 (Native Method)}}
{{ at java.lang.ClassLoader.defineClass (ClassLoader.java:1016)}}
{{ at java.security.SecureClassLoader.defineClass (SecureClassLoader.java:174)}}
{{ at java.net.URLClassLoader.defineClass (URLClassLoader.java:550)}}
{{ at java.net.URLClassLoader$1.run (URLClassLoader.java:458)}}
{{ at java.net.URLClassLoader$1.run (URLClassLoader.java:452)}}
{{ at java.security.AccessController.doPrivileged (Native Method)}}
{{ at java.net.URLClassLoader.findClass (URLClassLoader.java:451)}}
{{ at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClassFromSelf
(ClassRealm.java:425)}}
{{ at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass
(SelfFirstStrategy.java:42)}}
{{ at org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass
(ClassRealm.java:271)}}
{{ at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass
(ClassRealm.java:247)}}
{{ at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass
(ClassRealm.java:239)}}
{{ at
org.apache.maven.wagon.providers.http.wagon.shared.AbstractHttpClientWagon.createRetryHandler
(AbstractHttpClientWagon.java:451)}}
{{ at
org.apache.maven.wagon.providers.http.wagon.shared.AbstractHttpClientWagon.createClient
(AbstractHttpClientWagon.java:541)}}
{{ at
org.apache.maven.wagon.providers.http.wagon.shared.AbstractHttpClientWagon.<clinit>
(AbstractHttpClientWagon.java:537)}}
{{ at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0 (Native
Method)}}
{{ at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance
(NativeConstructorAccessorImpl.java:62)}}
{{ at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance
(DelegatingConstructorAccessorImpl.java:45)}}
{{ at java.lang.reflect.Constructor.newInstance (Constructor.java:490)}}
{{ at
com.google.inject.internal.DefaultConstructionProxyFactory$ReflectiveProxy.newInstance
(DefaultConstructionProxyFactory.java:126)}}
{{ at com.google.inject.internal.ConstructorInjector.provision
(ConstructorInjector.java:114)}}
{{ at com.google.inject.internal.ConstructorInjector.access$000
(ConstructorInjector.java:32)}}
{{ at com.google.inject.internal.ConstructorInjector$1.call
(ConstructorInjector.java:98)}}
{{ at
com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision
(ProvisionListenerStackCallback.java:112)}}
{{ at
com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision
(ProvisionListenerStackCallback.java:127)}}
{{ at com.google.inject.internal.ProvisionListenerStackCallback.provision
(ProvisionListenerStackCallback.java:66)}}
{{ at com.google.inject.internal.ConstructorInjector.construct
(ConstructorInjector.java:93)}}
{{ at com.google.inject.internal.ConstructorBindingImpl$Factory.get
(ConstructorBindingImpl.java:306)}}
{{ at com.google.inject.internal.InjectorImpl$1.get (InjectorImpl.java:1050)}}
{{ at com.google.inject.internal.InjectorImpl.getInstance
(InjectorImpl.java:1086)}}
{{ at org.eclipse.sisu.space.AbstractDeferredClass.get
(AbstractDeferredClass.java:48)}}
{{ at com.google.inject.internal.ProviderInternalFactory.provision
(ProviderInternalFactory.java:85)}}
{{ at
com.google.inject.internal.InternalFactoryToInitializableAdapter.provision
(InternalFactoryToInitializableAdapter.java:57)}}
{{ at com.google.inject.internal.ProviderInternalFactory$1.call
(ProviderInternalFactory.java:66)}}
{{ at
com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision
(ProvisionListenerStackCallback.java:112)}}
{{ at
com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision
(ProvisionListenerStackCallback.java:127)}}
{{ at com.google.inject.internal.ProvisionListenerStackCallback.provision
(ProvisionListenerStackCallback.java:66)}}
{{ at com.google.inject.internal.ProviderInternalFactory.circularGet
(ProviderInternalFactory.java:61)}}
{{ at com.google.inject.internal.InternalFactoryToInitializableAdapter.get
(InternalFactoryToInitializableAdapter.java:47)}}
{{ at com.google.inject.internal.InjectorImpl$1.get (InjectorImpl.java:1050)}}
{{ at org.eclipse.sisu.inject.Guice4$1.get (Guice4.java:162)}}
{{ at org.eclipse.sisu.inject.LazyBeanEntry.getValue (LazyBeanEntry.java:81)}}
{{ at org.eclipse.sisu.plexus.LazyPlexusBean.getValue (LazyPlexusBean.java:51)}}
{{ at org.codehaus.plexus.DefaultPlexusContainer.lookup
(DefaultPlexusContainer.java:263)}}
{{ at org.codehaus.plexus.DefaultPlexusContainer.lookup
(DefaultPlexusContainer.java:255)}}
{{ at org.eclipse.aether.internal.transport.wagon.PlexusWagonProvider.lookup
(PlexusWagonProvider.java:56)}}
{{ at org.eclipse.aether.transport.wagon.WagonTransporter.lookupWagon
(WagonTransporter.java:279)}}
{{ at org.eclipse.aether.transport.wagon.WagonTransporter.<init>
(WagonTransporter.java:123)}}
{{ at org.eclipse.aether.transport.wagon.WagonTransporterFactory.newInstance
(WagonTransporterFactory.java:116)}}
{{ at
org.eclipse.aether.internal.impl.DefaultTransporterProvider.newTransporter
(DefaultTransporterProvider.java:104)}}
{{ at org.eclipse.aether.connector.basic.BasicRepositoryConnector.<init>
(BasicRepositoryConnector.java:129)}}
{{ at
org.eclipse.aether.connector.basic.BasicRepositoryConnectorFactory.newInstance
(BasicRepositoryConnectorFactory.java:155)}}
{{ at
org.eclipse.aether.internal.impl.DefaultRepositoryConnectorProvider.newRepositoryConnector
(DefaultRepositoryConnectorProvider.java:107)}}
{{ at org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads
(DefaultArtifactResolver.java:496)}}
{{ at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve
(DefaultArtifactResolver.java:401)}}
{{ at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts
(DefaultArtifactResolver.java:229)}}
{{ at
org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveDependencies
(DefaultRepositorySystem.java:340)}}
{{ at org.apache.maven.project.DefaultProjectDependenciesResolver.resolve
(DefaultProjectDependenciesResolver.java:202)}}
{{ at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies
(LifecycleDependencyResolver.java:243)}}
{{ at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies
(LifecycleDependencyResolver.java:147)}}
{{ at
org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved
(MojoExecutor.java:248)}}
{{ at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:202)}}
{{ at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:156)}}
{{ at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:148)}}
{{ at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:117)}}
{{ at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:81)}}
{{ at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:56)}}
{{ at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:128)}}
{{ at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)}}
{{ at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)}}
{{ at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)}}
{{ at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)}}
{{ at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)}}
{{ at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)}}
{{ at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)}}
{{ at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)}}
{{ at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)}}
{{ at java.lang.reflect.Method.invoke (Method.java:566)}}
{{ at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
(Launcher.java:282)}}
{{ at org.codehaus.plexus.classworlds.launcher.Launcher.launch
(Launcher.java:225)}}
{{ at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
(Launcher.java:406)}}
{{ at org.codehaus.plexus.classworlds.launcher.Launcher.main
(Launcher.java:347)}}
{{Caused by: java.lang.ClassNotFoundException:
org.apache.http.client.HttpRequestRetryHandler}}
{{ at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass
(SelfFirstStrategy.java:50)}}
{{ at org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass
(ClassRealm.java:271)}}
{{ at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass
(ClassRealm.java:247)}}
{{ at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass
(ClassRealm.java:239)}}
{{ at java.lang.ClassLoader.defineClass1 (Native Method)}}
{{ at java.lang.ClassLoader.defineClass (ClassLoader.java:1016)}}
{{ at java.security.SecureClassLoader.defineClass (SecureClassLoader.java:174)}}
{{ at java.net.URLClassLoader.defineClass (URLClassLoader.java:550)}}
{{ at java.net.URLClassLoader$1.run (URLClassLoader.java:458)}}
{{ at java.net.URLClassLoader$1.run (URLClassLoader.java:452)}}
{{ at java.security.AccessController.doPrivileged (Native Method)}}
{{ at java.net.URLClassLoader.findClass (URLClassLoader.java:451)}}
{{ at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClassFromSelf
(ClassRealm.java:425)}}
{{ at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass
(SelfFirstStrategy.java:42)}}
{{ at org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass
(ClassRealm.java:271)}}
{{ at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass
(ClassRealm.java:247)}}
{{ at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass
(ClassRealm.java:239)}}
{{ at
org.apache.maven.wagon.providers.http.wagon.shared.AbstractHttpClientWagon.createRetryHandler
(AbstractHttpClientWagon.java:451)}}
{{ at
org.apache.maven.wagon.providers.http.wagon.shared.AbstractHttpClientWagon.createClient
(AbstractHttpClientWagon.java:541)}}
{{ at
org.apache.maven.wagon.providers.http.wagon.shared.AbstractHttpClientWagon.<clinit>
(AbstractHttpClientWagon.java:537)}}
{{ at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0 (Native
Method)}}
{{ at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance
(NativeConstructorAccessorImpl.java:62)}}
{{ at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance
(DelegatingConstructorAccessorImpl.java:45)}}
{{ at java.lang.reflect.Constructor.newInstance (Constructor.java:490)}}
{{ at
com.google.inject.internal.DefaultConstructionProxyFactory$ReflectiveProxy.newInstance
(DefaultConstructionProxyFactory.java:126)}}
{{ at com.google.inject.internal.ConstructorInjector.provision
(ConstructorInjector.java:114)}}
{{ at com.google.inject.internal.ConstructorInjector.access$000
(ConstructorInjector.java:32)}}
{{ at com.google.inject.internal.ConstructorInjector$1.call
(ConstructorInjector.java:98)}}
{{ at
com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision
(ProvisionListenerStackCallback.java:112)}}
{{ at
com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision
(ProvisionListenerStackCallback.java:127)}}
{{ at com.google.inject.internal.ProvisionListenerStackCallback.provision
(ProvisionListenerStackCallback.java:66)}}
{{ at com.google.inject.internal.ConstructorInjector.construct
(ConstructorInjector.java:93)}}
{{ at com.google.inject.internal.ConstructorBindingImpl$Factory.get
(ConstructorBindingImpl.java:306)}}
{{ at com.google.inject.internal.InjectorImpl$1.get (InjectorImpl.java:1050)}}
{{ at com.google.inject.internal.InjectorImpl.getInstance
(InjectorImpl.java:1086)}}
{{ at org.eclipse.sisu.space.AbstractDeferredClass.get
(AbstractDeferredClass.java:48)}}
{{ at com.google.inject.internal.ProviderInternalFactory.provision
(ProviderInternalFactory.java:85)}}
{{ at
com.google.inject.internal.InternalFactoryToInitializableAdapter.provision
(InternalFactoryToInitializableAdapter.java:57)}}
{{ at com.google.inject.internal.ProviderInternalFactory$1.call
(ProviderInternalFactory.java:66)}}
{{ at
com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision
(ProvisionListenerStackCallback.java:112)}}
{{ at
com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision
(ProvisionListenerStackCallback.java:127)}}
{{ at com.google.inject.internal.ProvisionListenerStackCallback.provision
(ProvisionListenerStackCallback.java:66)}}
{{ at com.google.inject.internal.ProviderInternalFactory.circularGet
(ProviderInternalFactory.java:61)}}
{{ at com.google.inject.internal.InternalFactoryToInitializableAdapter.get
(InternalFactoryToInitializableAdapter.java:47)}}
{{ at com.google.inject.internal.InjectorImpl$1.get (InjectorImpl.java:1050)}}
{{ at org.eclipse.sisu.inject.Guice4$1.get (Guice4.java:162)}}
{{ at org.eclipse.sisu.inject.LazyBeanEntry.getValue (LazyBeanEntry.java:81)}}
{{ at org.eclipse.sisu.plexus.LazyPlexusBean.getValue (LazyPlexusBean.java:51)}}
{{ at org.codehaus.plexus.DefaultPlexusContainer.lookup
(DefaultPlexusContainer.java:263)}}
{{ at org.codehaus.plexus.DefaultPlexusContainer.lookup
(DefaultPlexusContainer.java:255)}}
{{ at org.eclipse.aether.internal.transport.wagon.PlexusWagonProvider.lookup
(PlexusWagonProvider.java:56)}}
{{ at org.eclipse.aether.transport.wagon.WagonTransporter.lookupWagon
(WagonTransporter.java:279)}}
{{ at org.eclipse.aether.transport.wagon.WagonTransporter.<init>
(WagonTransporter.java:123)}}
{{ at org.eclipse.aether.transport.wagon.WagonTransporterFactory.newInstance
(WagonTransporterFactory.java:116)}}
{{ at
org.eclipse.aether.internal.impl.DefaultTransporterProvider.newTransporter
(DefaultTransporterProvider.java:104)}}
{{ at org.eclipse.aether.connector.basic.BasicRepositoryConnector.<init>
(BasicRepositoryConnector.java:129)}}
{{ at
org.eclipse.aether.connector.basic.BasicRepositoryConnectorFactory.newInstance
(BasicRepositoryConnectorFactory.java:155)}}
{{ at
org.eclipse.aether.internal.impl.DefaultRepositoryConnectorProvider.newRepositoryConnector
(DefaultRepositoryConnectorProvider.java:107)}}
{{ at org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads
(DefaultArtifactResolver.java:496)}}
{{ at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve
(DefaultArtifactResolver.java:401)}}
{{ at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts
(DefaultArtifactResolver.java:229)}}
{{ at
org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveDependencies
(DefaultRepositorySystem.java:340)}}
{{ at org.apache.maven.project.DefaultProjectDependenciesResolver.resolve
(DefaultProjectDependenciesResolver.java:202)}}
{{ at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies
(LifecycleDependencyResolver.java:243)}}
{{ at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies
(LifecycleDependencyResolver.java:147)}}
{{ at
org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved
(MojoExecutor.java:248)}}
{{ at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:202)}}
{{ at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:156)}}
{{ at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:148)}}
{{ at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:117)}}
{{ at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:81)}}
{{ at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:56)}}
{{ at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:128)}}
{{ at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)}}
{{ at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)}}
{{ at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)}}
{{ at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)}}
{{ at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)}}
{{ at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)}}
{{ at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)}}
{{ at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)}}
{{ at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)}}
{{ at java.lang.reflect.Method.invoke (Method.java:566)}}
{{ at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
(Launcher.java:282)}}
{{ at org.codehaus.plexus.classworlds.launcher.Launcher.launch
(Launcher.java:225)}}
{{ at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
(Launcher.java:406)}}
{{ at org.codehaus.plexus.classworlds.launcher.Launcher.main
(Launcher.java:347)}}
{{[INFO]
------------------------------------------------------------------------}}
{{[INFO] BUILD FAILURE}}
{{[INFO]
------------------------------------------------------------------------}}
{{[INFO] Total time: 6.706 s}}
{{[INFO] Finished at: 2020-01-28T08:10:55+01:00}}
{{[INFO]
------------------------------------------------------------------------}}
> Retry handler docs are possibly wrong
> -------------------------------------
>
> Key: WAGON-576
> URL: https://issues.apache.org/jira/browse/WAGON-576
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-http
> Affects Versions: 3.3.4
> Reporter: Michael Medin
> Priority: Minor
>
> The documentation for retry
> [https://maven.apache.org/wagon/wagon-providers/wagon-http/] says that a
> custom retry handler should implement org.apache.http.client.Interface
> HttpRequestRetryHandler.
> This is may not be true as at least the wagon-http used by Maven has packaged
> (forked) a custom version of common-httpclient inside so the interface which
> should be implemented in the case of Maven is actually
> org.apache.maven.wagon.providers.http.httpclient.client.HttpRequestRetryHandler.
>
> The reason I dont submit a PR fixing this is that I am unsure whether this is
> just an issue for how Maven uses wagon or if is an issue with wagon it self.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)