bmhm opened a new pull request #28: [MCHECKSTYLE-387] emit a warning when using an old version of checkstyle URL: https://github.com/apache/maven-checkstyle-plugin/pull/28 The commit will emit a warning if using a version of checkstyle which still has a successful call to the method `checker.setClassLoader`. Rationale: This method was deprecated for quite some time now. Merge after https://github.com/checkstyle/checkstyle/issues/7190 was fixed and released. Otherwise the user would not have a chance to circumvent this warning. This also means that this plugin needs to stay at checkstyle 8.29 for at least two releases. * If this plugni updated to soon, old versions of checkstyle would just stop working with a `NoSuchMethodError`. * If updated too early, the method call `checker.setClassLoader` would have been removed, so no version emitted a warning to the user. Emitting a warning for just one version is the most graceful way to notify users to upgrade while maintaining compatibility with both older and newer versions. --- Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCHECKSTYLE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MCHECKSTYLE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MCHECKSTYLE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
