elharo commented on a change in pull request #18: [MCHECKSTYLE-381] remove call
to checker.setClassLoader().
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/18#discussion_r385091608
##########
File path:
src/main/java/org/apache/maven/plugins/checkstyle/exec/DefaultCheckstyleExecutor.java
##########
@@ -316,6 +258,73 @@ public URLClassLoader run()
return checkerListener.getResults();
}
+ private void setUpCheckstyleClassloader( Checker checker,
+ List<String> classPathStrings,
+ List<String> outputDirectories )
+ throws CheckstyleExecutorException
+ {
+ final List<URL> urls = new ArrayList<>( classPathStrings.size() );
Review comment:
personal preference; but I tend not to use final on local variables where
it's not required. Up to you though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
