mthmulders commented on a change in pull request #286: [MNG-6656] Introduce
base for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r386295335
##########
File path:
maven-core/src/main/java/org/apache/maven/project/ReactorModelPool.java
##########
@@ -19,53 +19,120 @@
* under the License.
*/
-import java.io.File;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.Collections;
import java.util.HashMap;
+import java.util.HashSet;
import java.util.Map;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.Set;
+
+import org.apache.maven.model.Model;
/**
- * Holds all POM files that are known to the reactor. This allows the project
builder to resolve imported POMs from the
+ * Holds all Models that are known to the reactor. This allows the project
builder to resolve imported Models from the
* reactor when building another project's effective model.
*
* @author Benjamin Bentmann
+ * @Robert Scholte
*/
class ReactorModelPool
{
+ private final Map<GAKey, Set<Model>> modelsByGa = new HashMap<>();
+
+ private final Map<Path, Model> modelsByPath = new HashMap<>();
+
+ /**
+ * This used to be the only method, which
Review comment:
This sentence is not complete. I'm not sure if historical considerations
should be part of JavaDoc, by the way, but let's first await the updated
JavaDoc before disgressing into that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
