rfscholte commented on a change in pull request #286: [MNG-6656] Introduce base
for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r386618453
##########
File path:
maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java
##########
@@ -375,9 +454,7 @@ private ModelSource createStubModelSource( Artifact
artifact )
boolean noErrors =
build( results, interimResults, projectIndex, pomFiles, new
LinkedHashSet<>(), true, recursive,
- config );
-
- populateReactorModelPool( modelPool, interimResults );
+ config, poolBuilder );
Review comment:
The reactormodelpool was always there and holds all models of the reactor
during one project build. In case Maven is being reused, the reactormodelpool
is always refreshed. Having such pool is required for building the graph. This
pool holds exactly the information required to get versions by path or
groupId+artifactId.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
