michael-o commented on a change in pull request #286: [MNG-6656] Introduce base
for build/consumer process
URL: https://github.com/apache/maven/pull/286#discussion_r386393075
##########
File path:
maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java
##########
@@ -375,9 +454,7 @@ private ModelSource createStubModelSource( Artifact
artifact )
boolean noErrors =
build( results, interimResults, projectIndex, pomFiles, new
LinkedHashSet<>(), true, recursive,
- config );
-
- populateReactorModelPool( modelPool, interimResults );
+ config, poolBuilder );
Review comment:
Why do you pass around and reuse the builder? I have the feeling your are
misusing a build like a caching factory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
