Tibor17 commented on a change in pull request #36: Replace more deprecated and
unused code
URL:
https://github.com/apache/maven-dependency-plugin/pull/36#discussion_r389337306
##########
File path:
src/test/java/org/apache/maven/plugins/dependency/resolvers/ExcludeReactorProjectsDependencyFilterTest.java
##########
@@ -124,7 +119,7 @@ public Dependency getDependency() {
ArgumentCaptor<String> captor = ArgumentCaptor.forClass( String.class
);
verify( log ).debug( captor.capture() );
- assertThat( captor.getValue(), containsString( "Skipped dependency" )
);
+ assertTrue( captor.getValue().contains( "Skipped dependency" ) );
Review comment:
revert This.
`assertTrue` and the old JUnit assertios are the bad practice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
