Tibor17 commented on a change in pull request #11: [SUREFIRE-1556] fail fast on
empty element names
URL: https://github.com/apache/maven-shared-utils/pull/11#discussion_r392650583
##########
File path:
src/test/java/org/apache/maven/shared/utils/xml/PrettyPrintXmlWriterTest.java
##########
@@ -40,26 +37,24 @@
*/
public class PrettyPrintXmlWriterTest
{
- StringWriter w;
+ private StringWriter w = new StringWriter();;
- PrettyPrintXMLWriter writer;
+ private PrettyPrintXMLWriter writer = new PrettyPrintXMLWriter( w );
- @Before
- public void before()
- throws Exception
- {
- w = new StringWriter();
- writer = new PrettyPrintXMLWriter( w );
- }
-
- @After
- public void after()
- throws Exception
+
+ @Test
Review comment:
@elharo
In practice the last line with main code must be followed by `e.expect`. So
yes there is guarantee. It is clear that only that one line has to throw the
exception. If it does not, then the `ExpectedException` fails the build. That's
why it was designed in JUnit4. You can use the new `assertThrows` but it has
another meaning - wrapping the exception and checking a new errors or
exceptions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
