eolivelli commented on issue #240: [SUREFIRE-1658] TCP/IP Channel for forked Surefire JVM. Extensions API and SPI. Polymorphism for remote and local process communication. URL: https://github.com/apache/maven-surefire/pull/240#issuecomment-599186792 In order to activate TCP communication the user has to add this to the configuration of surefire: `<forkNode implementation="org.apache.maven.plugin.surefire.extensions.SurefireForkNodeFactory"/>` My suggestions: - to me the word "forkNode" does not tell much, what about "forkCommunicationMode" ? - better not to have a classname, but a string Examples: for new TCP implementation: `<forkCommunicationMode>tcp</forkCommunicationMode>` for legacy: `<forkCommunicationMode>stdio</forkCommunicationMode>` stdio stands for "Standard I/O" I think that this way: - it is self explaining for users - we will be free to reroute to a different classname or even class model/abstraction Very good that by default we are keeping the "legacy" implementation super great work @Tibor17 !
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
