elharo commented on a change in pull request #7: [MDEP-679] mvn
dependency:analyze detected wrong transitive dependency
URL:
https://github.com/apache/maven-dependency-analyzer/pull/7#discussion_r395208193
##########
File path:
src/main/java/org/apache/maven/shared/dependency/analyzer/asm/ConstantPoolParser.java
##########
@@ -142,9 +141,8 @@
buf.getChar();
buf.getChar();
break;
+ case CONSTANT_STRING:
Review comment:
This switch pattern is error prone. It's more reliable against future
changes if every case has its own code even when they're the same. If
necessary, extract a helper function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
