rfscholte commented on a change in pull request #10: fix a number of small
warnings and formatting issues
URL: https://github.com/apache/maven-shared-utils/pull/10#discussion_r396001319
##########
File path: src/test/java/org/apache/maven/shared/utils/io/SymlinkTestSetup.java
##########
@@ -36,18 +37,18 @@ public static File createStandardSymlinkTestDir( File root
)
srcDir.mkdirs();
File target = new File( srcDir, "targetDir" );
target.mkdirs();
- write( new File( target, "targetFile.txt" ), "a regular File payload"
);
+ write( new File( target, "targetFile.txt" ), "a regular File payload",
StandardCharsets.UTF_8 );
Review comment:
In general I prefer static imports for methods. For a constant like this I
like to include the classname.
It is a matter of taste, I'm fine with this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
