[ 
https://issues.apache.org/jira/browse/MENFORCER-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17064283#comment-17064283
 ] 

Kevin Leturc commented on MENFORCER-347:
----------------------------------------

This was indeed an issue fixed by LANG-1027. Nothing to do on enforcer side, it 
already depends on a commons-lang3 version having the fix.

Furthermore, I ran 
{{TestRequireJavaVersion#settingsTheJavaVersionAsNormalizedVersionShouldNotFail}}
 with java 14 and the {{SystemUtils#JAVA_SPECIFICATION_VERSION_AS_ENUM}} 
constant is evaluated to {{JavaVersion#JAVA_RECENT}} with {{14.0}} as value. 
Everything works as expected.

Is rework to use plexus instead still a wish?

> RequireJavaVersion should use plexus-java
> -----------------------------------------
>
>                 Key: MENFORCER-347
>                 URL: https://issues.apache.org/jira/browse/MENFORCER-347
>             Project: Maven Enforcer Plugin
>          Issue Type: Improvement
>          Components: Standard Rules
>            Reporter: Robert Scholte
>            Priority: Minor
>              Labels: up-for-grabs
>
> This rule is using {{SystemUtils.JAVA_VERSION}} to verify the Java version. 
> The downside of this solution is that it needs to be updated every 6 month 
> because it is using an enum to verify it.
> Several other plugins already use 
> https://codehaus-plexus.github.io/plexus-languages/plexus-java/usage.html to 
> compare Java versions, and it doesn't require to be updated with every new 
> Java release (as long as it keeps using the same versioning scheme of course)
> Better to replace this piece of code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to